-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saga view shows timeout hyperlink when message has not been processed #651
Comments
|
Agreed. Specially when the message handling is already scrolled into view. E.g. in the following example, clicking the link has no visible effect: I'm wondering if, after clicking, the incoming message should be highlighted somehow. It could even be a background highlight which fades out, similar to when clicking a StackOverflow question.
Just to throw a crazy idea out there, how about if we move the link to the requested message and make the meaning explicit? E.g. When the message is not processed, the text can be "(Not processed)" and not linked. |
As a bonus, we could even highlight both the requested timeout and the handled timeout boxes when the user hovers over either, to give a visual connection between the two. |
I've raised a WIP PR which does the simplest thing possible, i.e. no link, just text, when the message hasn't been processed: #653 |
The scope of this issue has been reduced to fixing only the bug that the timeout hyperlink is shown when the message has not been processed. Other proposals here will be moved to separate issues. |
A user in a google issue asked about the display of timeouts in a saga view. Specifically when a timeout does not occur there is still a hyperlink that leads nowhere, which was confusing the user.
We should probably change the hyperlink to standard text if the timeout did not fire, and optionally also add a tooltip saying that.
cc @sergioc
The text was updated successfully, but these errors were encountered: