Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saga view shows timeout hyperlink when message has not been processed #651

Closed
distantcam opened this issue Nov 29, 2016 · 5 comments · Fixed by #653
Closed

Saga view shows timeout hyperlink when message has not been processed #651

distantcam opened this issue Nov 29, 2016 · 5 comments · Fixed by #653
Assignees
Milestone

Comments

@distantcam
Copy link
Contributor

A user in a google issue asked about the display of timeouts in a saga view. Specifically when a timeout does not occur there is still a hyperlink that leads nowhere, which was confusing the user.

We should probably change the hyperlink to standard text if the timeout did not fire, and optionally also add a tooltip saying that.

cc @sergioc

@sergioc
Copy link

sergioc commented Nov 29, 2016

  1. I think the link alone is not clear enough in any case, so it would be good to have the tooltip indicating what's the link for at all times. Even after clicking it may not be entirely obvious.
  2. regarding timeouts that didn't yet fire, I'm unsure about using standard text. Because it's not a link it's unlikely the user will hover it and see the tooltip. Another option is to keep the link and trigger a message indicating the timeout didn't fire yet. Thoughts?

@adamralph
Copy link
Contributor

adamralph commented Nov 29, 2016

  1. I think the link alone is not clear enough in any case, so it would be good to have the tooltip indicating what's the link for at all times. Even after clicking it may not be entirely obvious.

Agreed. Specially when the message handling is already scrolled into view. E.g. in the following example, clicking the link has no visible effect:

image

I'm wondering if, after clicking, the incoming message should be highlighted somehow. It could even be a background highlight which fades out, similar to when clicking a StackOverflow question.


  1. regarding timeouts that didn't yet fire, I'm unsure about using standard text. Because it's not a link it's unlikely the user will hover it and see the tooltip. Another option is to keep the link and trigger a message indicating the timeout didn't fire yet. Thoughts?

Just to throw a crazy idea out there, how about if we move the link to the requested message and make the meaning explicit? E.g.

image

When the message is not processed, the text can be "(Not processed)" and not linked.

@adamralph
Copy link
Contributor

As a bonus, we could even highlight both the requested timeout and the handled timeout boxes when the user hovers over either, to give a visual connection between the two.

@adamralph
Copy link
Contributor

adamralph commented Nov 29, 2016

I've raised a WIP PR which does the simplest thing possible, i.e. no link, just text, when the message hasn't been processed: #653

image

@distantcam distantcam self-assigned this Dec 1, 2016
@adamralph adamralph changed the title Saga timeouts url does nothing Saga view shows timeout URL when message has not been processed Dec 1, 2016
@adamralph adamralph changed the title Saga view shows timeout URL when message has not been processed Saga view shows timeout hyperlink when message has not been processed Dec 1, 2016
@adamralph
Copy link
Contributor

adamralph commented Dec 1, 2016

The scope of this issue has been reduced to fixing only the bug that the timeout hyperlink is shown when the message has not been processed.

Other proposals here will be moved to separate issues.

@adamralph adamralph self-assigned this Dec 1, 2016
@adamralph adamralph added this to the 1.5.11 milestone Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants