Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FailedMessagesView: When message types are not present in the metadata from SC, then SP must display proper default values instead of NULL_TYPE #169

Closed
indualagarsamy opened this issue Dec 16, 2014 · 7 comments
Assignees
Labels
Type: Bug Type: Bug
Milestone

Comments

@indualagarsamy
Copy link
Contributor

For external integration scenarios when 3rd party systems are sending messages to NSB endpoints, they may not contain the EnclosedMessageTypes header.

When SC parses this information, the meta data for MessageType will be null.
We need to set proper value such as Not available - missing metadata EnclosedMessageTypes or something of the sort.

Relates to Particular/ServiceControl#429

@gbiellem
Copy link
Contributor

@indualagarsamy - this will be addressed as part of https://github.com/Particular/Requirements/issues/194 correct?

@indualagarsamy
Copy link
Contributor Author

@gbiellem - that's correct. we should.

@weralabaj
Copy link
Contributor

bug
This is how it currently looks like, seems like it was fixed as part of something else. Can we close this one? Or do we want do display different text, rather than "unknown"?
@gbiellem @indualagarsamy

@gbiellem
Copy link
Contributor

I'd prefer a bit more detail like Message Type Unknown or @indualagarsamy's suggestion of Not available - missing metadata EnclosedMessageTypes

@weralabaj
Copy link
Contributor

Ok, I'll go with 'Message Type Unknown - missing metadata EnclosedMessageTypes'.

@johnsimons johnsimons added this to the 1.2 milestone Aug 4, 2015
@weralabaj
Copy link
Contributor

@johnsimons that was done as part of 194, was merged and can be released independently of SC changes. Can be closed.

@johnsimons
Copy link
Member

Fixed in cee57dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants