Fixed assemblyinfo patching with stars #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
can this be tested? |
Contributor
|
There is now a test fixture in master covering this. If you rebase it should be easy to add a test |
Contributor
Author
|
Ok I'll add tests |
yannisgu
force-pushed
the
fixAssemblyPatching
branch
from
aacc9b6 to
3117804
Compare
When an AssemblyInfo contained a version like 1.0.0.* it wasn't recognized by GitVersion. Only 1.0.0.0 or 1.0.0* worked.
yannisgu
force-pushed
the
fixAssemblyPatching
branch
from
3117804 to
34385e8
Compare
Contributor
Author
|
Tests added, with correct style, now. |
JakeGinnivan
added a commit
that referenced
this pull request
Nov 25, 2014
Fixed assemblyinfo patching with stars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an AssemblyInfo.cs contained a version like 1.0.0.* it wasn't recognized by GitVersion. Only 1.0.0.0 or 1.0.0* worked.