Faster building, hopefully better actions workflow (#185)

* Faster building, hopefully better actions workflow

* More!!!

* Another test

* fix

* Hopefully fix Bintray publishing while we're at it

* Checkstyle doesn't need to wait until build is done anymore

* One last oopsie and we're good for merge.

Author: TheGlitch76

.github/workflows/build.yml

@@ -8,57 +8,40 @@ on:
 
 jobs:
   build:
+    strategy:
+      matrix:
+        java-version: [1.8, 11, 14]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-java@v1
         with:
-          java-version: 8
-      # https://github.com/actions/cache/blob/master/examples.md#java---gradle
-      - uses: actions/cache@v2
-        with:
-          path: ~/.gradle/caches
-          key: ${{ runner.os }}-gradle-build-${{ hashFiles('**/*.gradle*') }}
-          restore-keys: |
-            ${{ runner.os }}-gradle-
+          java-version: ${{ matrix.java-version }}
       - uses: eskatos/gradle-command-action@v1
         with:
+          gradle-version: wrapper
           arguments: remapJar
+          dependencies-cache-enabled: true
+          configuration-cache-enabled: false
       # Artifact publishing
       - uses: actions/upload-artifact@v2
+        # In theory we could publish the j11 or even j14 jar, but let's not take any chances
+        if: ${{ matrix.java-version == 1.8 }}
         with:
+          name: Jar Download
           path: ./build/libs/patchwork-api-?.?.?.jar
 
-  checkstyle:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-java@v1
-        with:
-          java-version: 8
-      - uses: actions/cache@v2
-        with:
-          path: ~/.gradle/caches
-          key: ${{ runner.os }}-gradle-checkstyle-${{ hashFiles('**/*.gradle*') }}
-          restore-keys: |
-            ${{ runner.os }}-gradle-
-      - uses: eskatos/gradle-command-action@v1
-        with:
-          arguments: checkstyleMain
 
-  license:
+  check:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-java@v1
         with:
-          java-version: 8
-      - uses: actions/cache@v2
-        with:
-          path: ~/.gradle/caches
-          key: ${{ runner.os }}-gradle-license-${{ hashFiles('**/*.gradle*') }}-license
-          restore-keys: |
-            ${{ runner.os }}-gradle-
+          java-version: 11
       - uses: eskatos/gradle-command-action@v1
         with:
-          arguments: checkLicenses
+          gradle-version: wrapper
+          arguments: licenseCheck checkstyleMain
+          dependencies-cache-enabled: true
+          configuration-cache-enabled: false

.github/workflows/publish.yml

@@ -8,16 +8,6 @@ env:
   bintray_key: ${{ secrets.bintray_key }}
 
 jobs:
-#  bintray:
-#    runs-on: ubuntu-latest
-#    steps:
-#      - uses: actions/checkout@v1
-#      - uses: actions/setup-java@v1
-#        with:
-#          java-version: 8
-#      - uses: eskatos/gradle-command-action@v1
-#        with:
-#          arguments: bintrayUpload
   release:
     runs-on: ubuntu-latest
     steps:
@@ -43,4 +33,7 @@ jobs:
           java-version: 8
       - uses: eskatos/gradle-command-action@v1
         with:
+          gradle-version: wrapper
           arguments: bintrayUpload
+          dependencies-cache-enabled: true
+          configuration-cache-enabled: false

build.gradle

@@ -3,7 +3,7 @@ plugins {
 	id 'eclipse'
 	id 'idea'
 	id 'maven-publish'
-	id 'fabric-loom' version '0.4-SNAPSHOT' apply false
+	id 'fabric-loom' version '0.5-SNAPSHOT' apply false
 	id 'net.minecrell.licenser' version '0.4.1'
 	id "org.ajoberstar.grgit" version "3.1.1"
 	id 'com.jfrog.bintray' version '1.8.4'
@@ -52,6 +52,14 @@ allprojects {
 
 	group = "net.patchworkmc.patchwork-api"
 
+	loom {
+		shareCaches = true
+	}
+
+	repositories {
+		maven { url 'https://dl.bintray.com/patchworkmc/Patchwork-Maven/' }
+	}
+
 	dependencies {
 		minecraft "com.mojang:minecraft:$Globals.mcVersion"
 		mappings "net.fabricmc:yarn:${Globals.mcVersion}${Globals.yarnVersion}:v2"
@@ -69,10 +77,6 @@ allprojects {
 		dev
 	}
 
-	repositories {
-		maven { url 'https://dl.bintray.com/patchworkmc/Patchwork-Maven/' }
-	}
-
 	jar {
 		classifier = "dev"
 	}
@@ -113,7 +117,7 @@ allprojects {
 
 	checkstyle {
 		configFile = rootProject.file("checkstyle.xml")
-		toolVersion = '8.25'
+		toolVersion = '8.31'
 	}
 }
 
@@ -136,39 +140,50 @@ subprojects {
 
 	publishing {
 		publications {
-			mavenJava(MavenPublication) {
-				artifact(file("${project.buildDir}/libs/$archivesBaseName-${version}-maven.jar")) {
-					builtBy remapMavenJar
-				}
-				artifact(sourcesJar) {
-					builtBy remapSourcesJar
+			create("${archivesBaseName}_mavenJava", MavenPublication) {
+				afterEvaluate {
+					artifact(file("${project.buildDir}/libs/$archivesBaseName-${version}-maven.jar")) {
+						builtBy remapMavenJar
+					}
+					artifact(sourcesJar) {
+						builtBy remapSourcesJar
+					}
 				}
 			}
 		}
+	}
 
-		repositories {
-			maven {
-				url "http://mavenupload.modmuss50.me/"
-				if (project.hasProperty('mavenPass')) {
-					credentials {
-						username 'buildslave'
-						password project.getProperty('mavenPass')
-					}
-				}
+	bintray {
+		user = project.hasProperty('bintrayUser') ? project.getProperty('bintrayUser') : System.getenv('bintray_user')
+		key = project.hasProperty('bintrayKey') ? project.getProperty('bintrayKey') : System.getenv('bintray_key')
+		publish = true
+		override = true
+		publications = ["${archivesBaseName}_mavenJava"]
+		pkg {
+			repo = project.bintrayRepo
+			name = archivesBaseName
+			user = bintray.user
+			userOrg = project.repoOwner
+			licenses = [project.codeLicense]
+			desc = project.description
+			websiteUrl = "https://github.com/${project.repoOwner}/${project.repoName}"
+			issueTrackerUrl = "https://github.com/${project.repoOwner}/${project.repoName}/issues"
+			vcsUrl = "https://github.com/${project.repoOwner}/${project.repoName}.git"
+			publicDownloadNumbers = true
+
+			githubRepo = "${project.repoOwner}/${project.repoName}"
+			version {
+				name = project.version
+				released = new Date()
 			}
 		}
 	}
 
 	javadoc.enabled = false
 }
 
-task remapMavenJar(type: net.fabricmc.loom.task.RemapJarTask, dependsOn: jar) {
-	afterEvaluate {
-		input = file("${project.buildDir}/libs/${archivesBaseName}-${version}-dev.jar")
-		archiveName = "${archivesBaseName}-${version}-maven.jar"
-		addNestedDependencies = false
-	}
-}
+subprojects.each { bintrayUpload.dependsOn("${it.path}:bintrayUpload") }
+
 bintray {
 	user = project.hasProperty('bintrayUser') ? project.getProperty('bintrayUser') : System.getenv('bintray_user')
 	key = project.hasProperty('bintrayKey') ? project.getProperty('bintrayKey') : System.getenv('bintray_key')
@@ -193,7 +208,18 @@ bintray {
 			released = new Date()
 		}
 	}
+
+	javadoc.enabled = false
 }
+
+task remapMavenJar(type: net.fabricmc.loom.task.RemapJarTask, dependsOn: jar) {
+	afterEvaluate {
+		input = file("${project.buildDir}/libs/${archivesBaseName}-${version}-dev.jar")
+		archiveName = "${archivesBaseName}-${version}-maven.jar"
+		addNestedDependencies = false
+	}
+}
+
 publishing {
 	publications {
 		mavenJava(MavenPublication) {
@@ -220,6 +246,7 @@ publishing {
 task licenseFormatAll
 subprojects {p -> licenseFormatAll.dependsOn("${p.path}:licenseFormat")}
 subprojects.each {remapJar.dependsOn("${it.path}:remapJar")}
+
 repositories {
 	flatDir {
 		dirs 'jars'
@@ -265,6 +292,10 @@ dependencies {
 	}
 }
 
+loom {
+	shareCaches = true
+}
+
 version = Globals.baseVersion //+ "+" + (ENV.BUILD_NUMBER ? ("build." + ENV.BUILD_NUMBER) : "local") + "-" + getBranch()
 
 logger.lifecycle("Building Patchwork: " + version)

gradle.properties

@@ -1,4 +1,8 @@
-org.gradle.jvmargs=-Xmx2G
+# Gradle needs a lot of memory to build in parallel.
+# If you're starved, you can reduce this to 1G and disable parallel building.
+org.gradle.jvmargs=-Xmx3G
+org.gradle.parallel=true
+org.gradle.daemon=false
 repoName=patchwork-api
 repoOwner=patchworkmc
 bintrayRepo=Patchwork-Maven

gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.3-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-all.zip

patchwork-extensions-block/build.gradle

@@ -8,6 +8,6 @@ dependencies {
 	implementation project(path: ':patchwork-tooltype', configuration: 'dev')
 }
 
-minecraft {
+loom {
 	accessWidener "src/main/resources/patchwork-extensions-block.accesswidener"
 }

patchwork-level-generators/build.gradle

@@ -7,6 +7,6 @@ dependencies {
 	implementation project(path: ':patchwork-events-world', configuration: 'dev')
 }
 
-minecraft {
+loom {
 	accessWidener "src/main/resources/patchwork-level-generators.accesswidener"
 }

patchwork-registries/build.gradle

@@ -6,6 +6,6 @@ dependencies {
 	implementation project(path: ':patchwork-fml', configuration: 'dev')
 }
 
-minecraft {
+loom {
 	accessWidener "src/main/resources/patchwork-registries.accesswidener"
 }

patchwork-tags/build.gradle

@@ -5,6 +5,6 @@ dependencies {
 	implementation project(path: ':patchwork-api-base', configuration: 'dev')
 }
 
-minecraft {
+loom {
     accessWidener "src/main/resources/patchwork-tags.accesswidener"
 }

settings.gradle

@@ -45,4 +45,3 @@ include 'patchwork-resource'
 include 'patchwork-tags'
 include 'patchwork-tooltype'
 include 'patchwork-vanilla-patches'
-