Skip to content

Commit 02cf10a

Browse files
committed
fix: turn update paths relative for wide installs
The updater is a fixed piece of older code that uses a Lua runtime that only handles paths that are representable in the user's text codepage. As the software may be installed in a location that cannot be expressed in that way, to mitigate the problem we turn all the paths in the update op-files into relative paths. That way as long as we never use exotic codepoints in our own paths it should be able to apply them cleanly and restart Path of Building afterward with a relative path. The updater executable can ironically enough not be updated at all with the related type of runtime hacks we introduced in SimpleGraphic as the updater deadlocks in updating itself. We have to work around its shortcomings in how we produce the op-files and possibly the update application script that runs under that limited runtime.
1 parent 8facc4d commit 02cf10a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/UpdateCheck.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ end
7878

7979
ConPrintf("Checking for update...")
8080

81-
local scriptPath = GetScriptPath()
82-
local runtimePath = GetRuntimePath()
81+
local scriptPath = "."
82+
local runtimePath = "."
8383

8484
-- Load and process local manifest
8585
local localVer

0 commit comments

Comments
 (0)