Skip to content

Commit 09917b5

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Dance with Death incorrectly working with Hollow Palm Technique (#1360)
We were applying weapon conditions even if a weapon didn't exist in the 2nd slot Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 32ac91c commit 09917b5

File tree

1 file changed

+27
-25
lines changed

1 file changed

+27
-25
lines changed

src/Modules/CalcPerform.lua

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -194,31 +194,33 @@ local function doActorAttribsConditions(env, actor)
194194
end
195195
end
196196
if actor.weaponData2.type then
197-
local info = env.data.weaponTypeInfo[actor.weaponData2.type]
198-
condList["Using"..info.flag] = true
199-
if actor.weaponData2.countsAsAll1H then
200-
actor.weaponData2["AddedUsingAxe"] = not condList["UsingAxe"]
201-
condList["UsingAxe"] = true
202-
actor.weaponData2["AddedUsingSword"] = actor.weaponData2.name:match("Varunastra") or not condList["UsingSword"] --Varunastra is a sword
203-
condList["UsingSword"] = true
204-
actor.weaponData2["AddedUsingDagger"] = not condList["UsingDagger"]
205-
condList["UsingDagger"] = true
206-
actor.weaponData2["AddedUsingMace"] = not condList["UsingMace"]
207-
condList["UsingMace"] = true
208-
actor.weaponData2["AddedUsingClaw"] = not condList["UsingClaw"]
209-
condList["UsingClaw"] = true
210-
actor.weaponData2["AddedUsingSpear"] = not condList["UsingSpear"]
211-
condList["UsingSpear"] = true
212-
-- GGG stated that a single Varunastra satisfied requirement for wielding two different weapons
213-
condList["WieldingDifferentWeaponTypes"] = true
214-
end
215-
if info.melee then
216-
condList["UsingMeleeWeapon"] = true
217-
end
218-
if info.oneHand then
219-
condList["UsingOneHandedWeapon"] = true
220-
else
221-
condList["UsingTwoHandedWeapon"] = true
197+
if actor.weaponData2.type ~= "None" then
198+
local info = env.data.weaponTypeInfo[actor.weaponData2.type]
199+
condList["Using"..info.flag] = true
200+
if actor.weaponData2.countsAsAll1H then
201+
actor.weaponData2["AddedUsingAxe"] = not condList["UsingAxe"]
202+
condList["UsingAxe"] = true
203+
actor.weaponData2["AddedUsingSword"] = actor.weaponData2.name:match("Varunastra") or not condList["UsingSword"] --Varunastra is a sword
204+
condList["UsingSword"] = true
205+
actor.weaponData2["AddedUsingDagger"] = not condList["UsingDagger"]
206+
condList["UsingDagger"] = true
207+
actor.weaponData2["AddedUsingMace"] = not condList["UsingMace"]
208+
condList["UsingMace"] = true
209+
actor.weaponData2["AddedUsingClaw"] = not condList["UsingClaw"]
210+
condList["UsingClaw"] = true
211+
actor.weaponData2["AddedUsingSpear"] = not condList["UsingSpear"]
212+
condList["UsingSpear"] = true
213+
-- GGG stated that a single Varunastra satisfied requirement for wielding two different weapons
214+
condList["WieldingDifferentWeaponTypes"] = true
215+
end
216+
if info.melee then
217+
condList["UsingMeleeWeapon"] = true
218+
end
219+
if info.oneHand then
220+
condList["UsingOneHandedWeapon"] = true
221+
else
222+
condList["UsingTwoHandedWeapon"] = true
223+
end
222224
end
223225
end
224226
if actor.weaponData1.type and actor.weaponData2.type then

0 commit comments

Comments
 (0)