Skip to content

Commit 883a3f8

Browse files
authored
Fix crash when using Saviour Mirages in FullDPS (#6677)
* FIX: crash caused by missing output * FIX: crash caused by order of things
1 parent ff7c132 commit 883a3f8

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/Modules/CalcMirages.lua

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ local function calculateMirage(env, config)
3535
newSkill.skillCfg.skillCond["usedByMirage"] = true
3636
newSkill.skillData.limitedProcessing = true
3737
newSkill.skillTypes[SkillType.OtherThingUsesSkill] = true
38-
env.player.mainSkill.mirage = { }
39-
env.player.mainSkill.mirage.name = newSkill.activeEffect.grantedEffect.name
38+
4039
_ = config.preCalcFunc and config.preCalcFunc(env, newSkill, newEnv)
4140

4241
newEnv.player.mainSkill = newSkill
@@ -63,7 +62,11 @@ function calcs.mirages(env)
6362
local moreDamage = newSkill.skillModList:Sum("BASE", newSkill.skillCfg, "MirageArcherLessDamage")
6463
local moreAttackSpeed = newSkill.skillModList:Sum("BASE", newSkill.skillCfg, "MirageArcherLessAttackSpeed")
6564
local mirageCount = newSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "MirageArcherMaxCount")
65+
66+
env.player.mainSkill.mirage = { }
67+
env.player.mainSkill.mirage.name = newSkill.activeEffect.grantedEffect.name
6668
env.player.mainSkill.mirage.count = mirageCount
69+
6770
if not env.player.mainSkill.infoMessage then
6871
env.player.mainSkill.infoMessage = tostring(mirageCount) .. " Mirage Archers using " .. newSkill.activeEffect.grantedEffect.name
6972
end
@@ -81,9 +84,7 @@ function calcs.mirages(env)
8184
end
8285
end,
8386
postCalcFunc = function(env, newSkill, newEnv)
84-
-- Re-link over the output
8587
env.player.mainSkill.mirage.output = newEnv.player.output
86-
8788
if newSkill.minion then
8889
env.player.mainSkill.mirage.minion = {}
8990
env.player.mainSkill.mirage.minion.output = newEnv.minion.output

0 commit comments

Comments
 (0)