Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infernal Legion ignoring support gem damage modifiers. e.g. Elemental Focus/Burning Damage Support. #5936

Closed
3 tasks done
bunpro opened this issue Apr 5, 2023 · 2 comments · Fixed by #6322
Closed
3 tasks done
Labels
bug: behaviour Behavioral differences

Comments

@bunpro
Copy link

bunpro commented Apr 5, 2023

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Check for support

  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the behaviour in-game?

In game, Infernal Legion's damage is affected by support gems such as Elemental Focus & Burning Damage.

What is the behaviour in Path of Building?

PoB these gems don't affect the damage calculations.
This used to work in previous versions of PoB.

How to reproduce the issue

Add Skitterbots Support Gem.
Add Infernal Legion Support to the Skitterbots.
Add Burning Damage to the Infernal Legion + Skitterbots setup.
Check the damage calculations to see no change.

Character build code

eNqtXG1v27YW_rz8CsLAgA27iS3JdtMg2eC81kDcenbS3ftpoCXa1kqJrkQldYf-93tISrZsizIVqQVaRTzn4TmHPG8048s_vgUUvZAo9ll41bLOOi1EQpd5fri4aj0_3Z-et_74_eRyjPny0_w68akY-f3kp0v5jCh5IRT4WojjaEH45wzJ-RuQVjjkS8LCEf6HRQ_Mu2p9ZCFpoRkOPZ9nP7kUx_FHHJCr1tQF5hbCsUtC72b7PiVc4gi7nESPYtZBwtmIeTDKowRGA-yHU-Z-IfwhYslKCvXik1dFMxyNP02eciL5YV4k0OinyzHFaxJNOeYohn-uWgMwDF6QDz4HKEwTwOm02qW010kU81scwONxnumKEO842Tgid_M5cbn_Qm4in98scegawFelHSWU-yvqk2hDb531dBwfDsCtjhb-iXFMb8fT44IoSmZg8b98vrymYEEjXEE9XIQ-J8bkY-bHLKwktRHxTUIpeJER7YTEJHrB3DcU5IYFMz80tMkNY9Rjr2FuuTu2o93hEcGf5monTrDnJ_GGz9FOMcIhvmGxwXIKyjGJwPN5JYYpcRkEi6pzVOR89OfEnLKSHilDVWnepsfd1JSuMvDbBJpApDSjnLKEGlLybQSzS1zra57Q6p7rKG_JNzO8PGFfCzcMuRlcntCyLL14L4zLxGkUpu4-jLeozrv3Z47Vcbrdc_tdX5uBluvYdzEd4W9-kAQQ-p_wFxLmtLD1W3Wx5CGEOx3vudZO935EdFzvuvqgRr3qc0EqY3F1NuGIuR1UlundC0E8DF0z934OIxn6cwVCCb7gmIDXiSJkRokpy3aS1HlNcrmaa0HCdMK1mUKPhLjLByjSJpgTs1C9oeqVG1bQGhlWEBYYtmtGv2-j8zI2jYXO3pcxVbTRXUiixXq69An1qlFngt3glVGZ6l7kuY1svTtdpe2SZ61okr9w5JklnaoyveA4H2Otfrm5FLnZriRQxQKDR0yr9XHE_hH9AK3GNogClmwzXrdnl-qgyI1UyBKE6nwmxEvcnYz0Xst5TaFnM1UAxKK0EseAc-x-uWXeglSapDrHNFmtIFKIVTflEwkOCnw_V9Ocvjeg_gRb1shzRS7cn6BvQG08wSa7m8-yx2Kui8jQFZTZkhtPsemyRxAUAgj1skEfsVwK1i4O9HT5nsvq2R3nrP_esR27lGe3ZyxgS5GnX3xKUSz-HeMIuFsoBu90iXza4KFb9oSqCjJmr2ChpTjBiQ18PUcNFdO2CdTqGZHw-9oYf4fcaIK70Esi4XLGc-xzFE0z8kPw5cMjHs3pzgH57umOVZNMe4KiocydoBRsgQMmcd5xfC8WsmnPYAqp9WcwheT6Mxit3lV1KDmOOaA9chxziF1wHGMi025fYXXelxGWVzKFLOVV1QFLaaFZSl1RNvPK78kPoGyK41vMMfLSDvgzjnwcclse_sYER-7yERLAPaZ0BmWADJWbt-KnPUYrc8DLtjzfFk_DYMUiLl_eYOrGcvZhuEo4CuXhdODH7t-zZD4XJ80iFkfy8Pzu_v7u5mn4-S4VOM8iw_jfYRLMxFmr-n_r-1MiiycUJ7NYPV61PvvkVaaAW8KxTyHEuYxSvIqJd9WaYxrDzD48SpopWMblJWiSCtrcLJQVY20J9Eh330jEQV-ou93IJ1q5NuNHhFITit0iFliHJqKbHkjVfDc45mrnaCwl464eRZyIa9URgyW8sGcw1c6cjh6xBF-vSAxluD_3XeEh5Uv-BNSKqsQurgtJz12XrHdaueoxZLDXAahBPbMK5jrudLTEqjJ1aK2qRvXst8TFWt3VoJ55E4xYKD8OKkbZUJUgfYTUITY5OM3Ap6LK1K7sHSUbEj3gJ74kkSpdtUgjiFEZSanjRP4s4Xo3zlGU2EomL42FxJieVZ36aHQQYyWRaCdHaQyap9FDqUMEbSArY1Udh9Z-af9SsgRpi64xvxotMUJ2SqHRPx0ucRIZfwcvzPdUD6txlz2ysoAB3Xp9GNmP14fZ79TrI95THH_Rrnc6qmd_5j71-boARX2qbQQinKoegvCtegiT_UJiyzspLyFk_LolcwKGLg1gG5qS9eVJeAtJjpesrSGUFKvYEbaqVcJSobxQ08qIaoOmH1OU7WFFcgQIctGHkmrHDGlzevKBYCo6N0brAR58HFNLT8ZjHHq3oh-pqahoZ5IVgGWSfSoqV7dLuo962c4aiUtZu8Uohg7jgQTx9RoaxXuRnfZaRywNmxb3XLU3eZ5sOo_McULF-z8TLAKLaJhybx_VfZ2QRcHm0zyAWrJXERQVoiglY8g1j49qZEB5Ciamy-ylrJMKJNW05Lv0pbyOM9hKLTWWcvuhSxOPDMP0YCsTneKZEE3cPxIfYW0sGFMmbpsQcB7e2ofdzPrTJQiXsj5QNsPU3gAIwrTT3BUlN5K-BALOSTRjXByGtrL7TXantYNt7WAPvTxjfDgjALTQV2XDoSw25Xq00IIE4ucR9HQe9LHtIQcLt4WZ25IRnqZJEEiYLfzX3NLuGQs2Zqi2h2g0xSk-iCYRkE7CA6XbxwxqbhS1p9Q8Wa9Z1Q6bfVkIY2oExYzy_WyTKiobQ70uIjymqszDKsy_WWEtaGXtNxgIKsh18-oPQzciGMLedRKJo_3aa30E0FTvlHt32S-Vb8kA1s4imAzLKhqLx6eIkCzoSiQrDXjwQ_56otCkI6JSDA60TjssEcRC5okg2js_d5wW4gCXuxppW-mtR8WupHqePKplWXK-ii_a7dfX17MV5ks2J998Ss5cFrRXwAQyncoFOBWw7QH8uV4M5B-lXoZ0qa5Dxu1UVZBdqimUEw8fGfRxYky8zH6QqovTpvSkbMojoc93xoL_SV1FSoAMz0d4tcmdYjRNLU6aTjjmtz7YI5KVTLZIgvC_2SHepVz61MziOUttSUzUFaK_CF5B8BOvc1lHkKIXdWInJ8xlnwm85usL9Pxx-Ofz3cnTkqB7SHbipBANQxAnZCcTtgZPgL2xYCHhJ6qpukDdnp0-X8POSz_sB8NfoM7JI8GLBJ6uYVe6y5P0uPACjSOCnDOrf9bZf2db-Xc3SQSG4CfqZI54aDPi7IuT5toLZHdO0gW8QJNT-fdEGnlCvl6gfu9kGKyo7_pivHPyb2qQC-eH4oJJHqR5QZxYORa8mq2VcyOnk9oD5n4kC9iZWwjrP_aPfyMcLshF56z345fzzqlld379WeRu5ZZIGUrL8tsv3c5pr_Mr4gycQ5YZSHQpeTF3yPswRaeA_tTp_Cxeig8_0TYC7k58_jNic5R9Bp16O5pHLECirEVclF7gtgpFDecQfihlkB_nFARDPYcuXq3gWTu5rWMVFeExZudHmpSEolUQhGuPmDcR5kPSiOJiSS_zgzTKaSnsoxTOUYruUYreUYr-UYp3RynOj1Jkn5zIPLMJH6Jm1UeZ3XIW6k_kA894BoFVxnZ5hg8p8UWkdzGk4ni7nEFNg6wKLNcMqjU0mK3jGPa18mvUqwJAKN_ntyvwy7YfOW_QEk1f8Wp_6u5bgGqon2LYDWAUK9RvQKF-Awq9CaNIodq702nAInZT2lTZb6rDrGWPAmfr15bAroywZbDeNqXTlP17DWwGqwH3sBqQo1txJzQVYuy6HtltwIDVc0ZjIdapq79d04WrCeCt09q4zh5UtUUdhGLH7tVG6De1rFZTMab61qxvx27ttew1s6mqKD8IEkp4A5HQaSCgODWdsluT32rG_m_OlJU3bbcyx1uqqJpW7dWN1Q0tS7ep4NJYXf3mFqoC30Qcddq1Q5PdzBo0limaaPi6b9OpqvHr5_iGio1ebUHqp7h-1WBQN3gcTqhOfbLjfXncLO9xsnDuLw5uZe5_XcH2Lqf8joDDa5wRUVfwxY2v3cufg893k8FD0dXP_S8gODoJCUmwHsbXLI7NaKf-dzIWv7PGt_Qj4vlJUMChvoqhEHhMsUuWjHok2oFX99WzS6vv8r8oWESf_koQo1Qe0OU5yxkzF8zobbucPv91BxlP7zhL9tFSxuIcEWtzxSpj6L8rZ9j93aic_tllgHQ3Xrb3v2Xj_3VEoXI=

Screenshots

image
image

@bunpro bunpro added the bug: behaviour Behavioral differences label Apr 5, 2023
@Wires77
Copy link
Member

Wires77 commented Apr 5, 2023

Likely caused by #5874 and #5894

@Paliak
Copy link
Contributor

Paliak commented Aug 13, 2023

This seems similar to #5755 . The infernal legion minion skill has no skillTypes

skills["InfernalLegion"] = {
name = "Infernal Legion",
hidden = true,
color = 4,
baseFlags = {
spell = true,
area = true,
},
skillTypes = { },
baseMods = {
skill("FireDot", 1, { type = "Multiplier", var = "InfernalLegionBaseDamage" }),
skill("dotIsArea", true),
},
qualityStats = {
},
stats = {
},
levels = {
[1] = { cost = { } },
},
}

adding SkillType.CausesBurning makes the supports work correctly but it also adds an unnecessary Skill Hit Damage section.

obraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants