Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SimpleApp] Unable to add notes again after already added #337

Closed
PatilShreyas opened this issue Nov 18, 2021 · 0 comments · Fixed by #331
Closed

[SimpleApp] Unable to add notes again after already added #337

PatilShreyas opened this issue Nov 18, 2021 · 0 comments · Fixed by #331
Labels
bug Something isn't working noty-android
Milestone
v1.3.2

Comments

@PatilShreyas
Copy link
Owner

On clicking Add new note FAB, the screen opens and closes instantly.

That's because earlier ViewModel instance holding previous addNoteState because in the SharedFlow we defined replay as 1 (by default).
@PatilShreyas PatilShreyas added this to the v1.3.2 milestone Nov 18, 2021
@PatilShreyas PatilShreyas linked a pull request Nov 18, 2021 that will close this issue
Fixes #329. Multiple Fixes and Improvements as stated in #330 #331
Merged
5 tasks
@PatilShreyas PatilShreyas added the bug Something isn't working label Nov 18, 2021
@PatilShreyas PatilShreyas moved this to Done in NotyKT Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working noty-android
Projects
NotyKT
Status: Done
Milestone
v1.3.2
Development

Successfully merging a pull request may close this issue.

Fixes #329. Multiple Fixes and Improvements as stated in #330 kasem-sm/NotyKT
1 participant
@PatilShreyas