-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Feature Request: Pin Notes #541
Comments
Heyy @PatilShreyas I can take this up... should I start working on this feature?? |
Thanks for showing interest in contributing this @mrfamouskk7. Sure, Assigning this to you. |
Thanks @PatilShreyas |
Let me know if you need any help in setting up this project locally. |
Actually, I am done with local setup. |
Yes, it'll be required to have isPinned flag in all notes response. If you're fine with doing it in the same PR, then okay. Otherwise we can also have a dedicated PR for that. |
@mrfamouskk7 Current API looks good to you? Otherwise, we can also have two API endpoints for pin and unpin operations. Like,
This will not require a request body. WDYT? |
I think both the ways should okay:
But it seems unusual/unconventional to have |
I will include in the same PR |
Makes sense! |
Heyy Shreyash, so I have a couple of suggestions:
WDYT? |
@mrfamouskk7 this sounds good to me. Definitely we can have |
Sure... I will add those changes in the same PR 👍 |
This is regarding feature "pinning notes" as discussed here: #534
This also needs to be implemented on the backend side so that the state of the pinning of notes will be persisted.
Task
Create an API for updating the note's pin.
API Contract
Request
Response
1. When note gets pinned/unpinned successfully
Response Code: 200
2. When note note exist in system
Response Code: 404
3. When unauthorized user tries to update note pin
Response Code: 401
The text was updated successfully, but these errors were encountered: