Skip to content

Commit a40fc0f

Browse files
committed
fix(pat navigation): Rename scroll-marker- options to scroll-item.
Implement review comments. This is not listed as "breaking" change because this change on the scroll-marker feature happens within the alpha phase.
1 parent cdaa86f commit a40fc0f

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

src/pat/navigation/navigation.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,9 @@ parser.addArgument("in-view-class", "in-view");
1717
parser.addArgument("current-class", "current");
1818
parser.addArgument("current-content-class", "navigation-current");
1919

20-
// Side of element that scrolls. top/bottom/middle/auto (default 'top')
21-
parser.addArgument("scroll-marker-side", "top", ["top", "bottom", "middle", "auto"]);
22-
// Distance from side of scroll box. any amount in px or % (default '50%')
23-
parser.addArgument("scroll-marker-distance", "50%");
24-
// Visibility of element in scroll box. most-visible or null (default null)
25-
parser.addArgument("scroll-marker-visibility", null, [null, "most-visible"]);
20+
parser.addArgument("scroll-item-side", "top", ["top", "bottom", "middle", "auto"]);
21+
parser.addArgument("scroll-item-distance", "50%");
22+
parser.addArgument("scroll-item-visibility", null, [null, "most-visible"]);
2623

2724
class Pattern extends BasePattern {
2825
static name = "navigation";
@@ -41,9 +38,9 @@ class Pattern extends BasePattern {
4138
"current-class": this.options["current-class"],
4239
"current-content-class": this.options["current-content-class"],
4340
"in-view-class": this.options["in-view-class"],
44-
"side": this.options["scroll-marker-side"],
45-
"distance": this.options["scroll-marker-distance"],
46-
"visibility": this.options["scroll-marker-visibility"],
41+
"side": this.options["scroll-item-side"],
42+
"distance": this.options["scroll-item-distance"],
43+
"visibility": this.options["scroll-item-visibility"],
4744
});
4845

4946
this.debounced_scroll_marker_enabler = utils.debounce(() => {

0 commit comments

Comments
 (0)