fix(pat-ajax): Support anchors without a href attribute and forms without an action attribute.

The URL can still be set via the data-pat-ajax attribute.
This fixes a problem where pat-inject enabled forms without an action attribute
but a submit button with a formaction attribute would break.

Author: thet

src/pat/ajax/ajax.js

@@ -14,9 +14,8 @@ const log = logging.getLogger("pat.ajax");
 export const parser = new Parser("ajax");
 parser.addArgument("accept", "text/html");
 parser.addArgument("url", function ($el) {
-    return (
-        $el.is("a") ? $el.attr("href") : $el.is("form") ? $el.attr("action") : ""
-    ).split("#")[0];
+    var val = $el.is("a") ? $el.attr("href") : $el.is("form") ? $el.attr("action") : "";
+    return (val || "").split("#")[0];
 });
 parser.addArgument("browser-cache", "no-cache", ["cache", "no-cache"]); // Cache ajax requests
 

src/pat/ajax/ajax.test.js

@@ -131,6 +131,18 @@ describe("pat-ajax", function () {
             const ajaxargs = $.ajax.mock.calls[$.ajax.mock.calls.length - 1][0];
             expect(ajaxargs.url).toEqual("else.html");
         });
+        it("Does not break with missing anchor-href", async function () {
+            document.body.innerHTML = `<a class="pat-ajax"/>`;
+            jest.spyOn(pattern.parser.log, "error");
+            pattern.parser.parse(document.body.querySelector(".pat-ajax"));
+            expect(pattern.parser.log.error).not.toHaveBeenCalled();
+        });
+        it("Does not break with missing form-action", async function () {
+            document.body.innerHTML = `<form class="pat-ajax"/>`;
+            jest.spyOn(pattern.parser.log, "error");
+            pattern.parser.parse(document.body.querySelector(".pat-ajax"));
+            expect(pattern.parser.log.error).not.toHaveBeenCalled();
+        });
 
         // Accept
         it("Default accept header", function () {