-
Notifications
You must be signed in to change notification settings - Fork 10
append_transient never returns 1 #15
Comments
Yup, the documentation is correct. The code is wrong. It would seem that the return code is never checked anywhere in the code. |
Ahh, got it. I'm working on a Python port of this (I'll post a link once I have something rough working), so I'm going over the code pretty closely. I'll let you know if I see anything else! |
Wow! Good luck. This code is quite a mess, as I was mostly trying to translate the core of Pink Trombone JS to ANSI C. So sorry about that. If you make a PR with this fix, I'll be happy to merge it. |
voc/tract.w
Line 413 in 20a17d6
Documentation states that append_transient should return 1 on success, but the function as written will never return 1. I think the last statement (line 413) should return 1. Unless I've missed something?
The text was updated successfully, but these errors were encountered: