-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The version check does not respect requirements #8
Comments
The same can be observed when a pre-release is available: |
I think the easiest would be to simply wait for https://github.com/hi-rustin/cargo-information to be merged directly in Cargo. It already does things intelligently, more so than I would be ready to do at least, and it being merged would mean no optional dependency trouble. |
Actually, rust-lang/cargo#11123 should be a preferable solution: not the easiest, but should be the best in terms of integration and report precision. |
Considering |
Nothing ideal, but further investigation is still needed. Overall though, |
Description
If a non-simple version requirement is used and there exists a version of the package newer enough to be outside of the requirement range, the version check reports a new version. That version is therefore displayed and
cargo install
is still called on it and it results in a no-op.Expected behavior
Only versions inside the requirement range should be considered and the call should not be made if there is no new version inside it.
To Reproduce
Steps to reproduce the behavior:
cargo liner ship
and let it finish the install.Output
Additional information
Fixing this won't be easy: it would need to rework the method used, most probably to move away from
cargo search
and to use requests to the registry API.Spawned from #6.
The text was updated successfully, but these errors were encountered: