Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onpopupopen is not called with other layers than Marker #113

Closed
amarant opened this issue Jan 21, 2016 · 2 comments
Closed

onpopupopen is not called with other layers than Marker #113

amarant opened this issue Jan 21, 2016 · 2 comments

Comments

@amarant
Copy link
Contributor

amarant commented Jan 21, 2016

Hi,
in a layer like this

<Circle
  center={[51.51, -0.06]}
  onpopupopen={() => {
    this.setState({circleClicks: this.state.circleClicks + 1})}
  }
  radius={400}
>
  <Popup>
    <span>{`Popup in Circle, clicks: ${this.state.circleClicks}`}</span>
  </Popup>
</Circle>

the onpopupopen event handler is not called, it only works with a Marker layer.
The fix #112 sets the second argument of the popup constructor to the popupContainer and makes it works.

Thanks.

@PaulLeCam
Copy link
Owner

Hi,
Thanks for the fix, I added it to master, it will go in the next release.

@PaulLeCam
Copy link
Owner

Published v0.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants