Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue support [Security Issue] #22

Open
xkill opened this issue Oct 18, 2019 · 1 comment
Open

Add queue support [Security Issue] #22

xkill opened this issue Oct 18, 2019 · 1 comment

Comments

@xkill
Copy link

xkill commented Oct 18, 2019

Hi,

I think that having a queue for multiple conversions.

If a server is doing multiple conversions, even if it all of them are with low priority, it hangs.
I suggest to have a queue, allowing only one (or multiple, settings could be changed) process at the same time.
The queue can be changed using the priorities, so when a high priority process is added to the queue, it should be at the top of the queue.

The users should be able to see the queue status. Not other users queue, but the position on the list. For example if the queue is:

  1. user1 -> video1 -> processing....
  2. user1 -> video2
  3. user2 -> video3
  4. user3 -> video4
  5. user1 -> video5

The user1, can see the queue as:

  1. user1 -> video1 -> position 1 -> processing....
  2. user1 -> video2 -> position 2
  3. user1 -> video5 -> position 5

The user2, only can see the queue as:
3. user2 -> video3 -> position 3

The users should also be able to cancel the queued jobs and, potentially cancel the current process.

NOTE: It is a security issue as the users can generate a DoS because of several concurrent processes.

EDIT: The denial of service can be done because two factors:

  • CPU consuming
  • RAM consuming (multiple instances of ffmpeg consume a lot of RAM)

CVE-2019-18214

@NicoleG25
Copy link

@PaulLereverend was this issue ever addressed?
Please note that CVE-2019-18214 was assigned to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants