Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document "Execute" event in "deployAndExecuteAndInstallPlugin" #157

Closed
PaulRBerg opened this issue Jul 7, 2023 · 0 comments · Fixed by #163
Closed

Document "Execute" event in "deployAndExecuteAndInstallPlugin" #157

PaulRBerg opened this issue Jul 7, 2023 · 0 comments · Fixed by #163

Comments

@PaulRBerg
Copy link
Owner

As noticed by @IaroslavMazur:

prb-proxy/src/interfaces/IPRBProxyRegistry.sol

Lines 178 to 187 in 27594d5

/// @dev Emits a {DeployProxy} and an {InstallPlugin} event.
///
/// Requirements:
/// - The caller must not have a proxy.
/// - See the requirements in `installPlugin`.
/// - See the requirements in `execute`.
///
/// @param plugin The address of the plugin to install.
/// @return proxy The address of the newly deployed proxy.
function deployAndExecuteAndInstallPlugin(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: document missing params in NatSpec PaulRBerg/prb-proxy
1 participant
@PaulRBerg