Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this line can damage your board #150

Open
ondra-novak opened this issue Dec 3, 2024 · 2 comments
Open

this line can damage your board #150

ondra-novak opened this issue Dec 3, 2024 · 2 comments

Comments

@ondra-novak
Copy link

OneWire/util/OneWire_direct_gpio.h

Line 512 in dae0fca

#define DIRECT_WRITE_HIGH(base, pin) digitalWrite(pin, HIGH)

a fallback version is dangerous because it actually sending 1 as active high. it should send it as high impedance. having device on the line with active low level, a shortcut can happen. I already experienced such event resulting dead board.
@ondra-novak
Copy link
Author

I have dropped this library and implemented own more safe version.

@uzi18
Copy link

uzi18 commented Dec 7, 2024

@ondra-novak just use OneWireNg safely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uzi18 @ondra-novak