Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessions historically associated with multiple species can cause invalid editions to appear in results. #32

Closed
JacobsonMT opened this issue Mar 9, 2018 · 0 comments
Assignees
Labels

Comments

@JacobsonMT
Copy link
Contributor

JacobsonMT commented Mar 9, 2018

Some accessions (~300) were in early editions associated with multiple species (ex. http://www.uniprot.org/uniprot/P84099) . The current assumption is that accessions are specific to a protein product and therefore a gene and a species, this assumption (apparently) only holds in recent editions.

A hypothetical situation where this can cause an issue: Asking for all annotations associated with one of these multi-species accessions might return data from its early years where some is from Human edition 14 and some is from Mouse edition 14, these editions are not concurrent and counting them together is incorrect.

Fix can either involve filtering out the annotations not associated with the desired species or modifying the logic of the algorithm to rely on the goa_release edition which was created to have an edition that satisfies the requirement of: goa_release1 == goa_release2 <-> goa_release1_date == goa_release2_date.

@JacobsonMT JacobsonMT added the bug label Mar 9, 2018
@JacobsonMT JacobsonMT self-assigned this Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant