This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
lucassaldanha
previously approved these changes
Nov 21, 2019
jframe
reviewed
Nov 21, 2019
jframe
previously approved these changes
Nov 22, 2019
@jframe don’t forget to put specific version in front of libsodium18. We
use docker lint in testDocker gradle task which will complain about it.
On Fri, 22 Nov 2019 at 10:43 am, Jason Frame ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docker/Dockerfile
<#304 (comment)>:
> @@ -0,0 +1,31 @@
+FROM openjdk:11.0.5-jre-slim-buster
+
+COPY orion /opt/orion/
+WORKDIR /opt/orion
+
+# Install libsodium
+RUN set -eux; \
+ apt-get update; \
+ apt-get install -y --no-install-recommends libsodium23=1.0.17-1; \
Changed the Docker to use same libsodium18 to be consistent with CI
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#304>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFDOV4AJMBXKJRB2WM7VZTQU4TLTANCNFSM4JP5WHZA>
.
--
*Usman Saleem // Blockchain Protocol Engineer*
usman.saleem@consensys.net
Brisbane, Australia
Web <https://consensys.net/> | Twitter <https://twitter.com/ConsenSys> |
Facebook <https://www.facebook.com/consensussystems> | Linkedin
<https://www.linkedin.com/company/consensus-systems-consensys-> | Newsletter
<http://consensys.us11.list-manage.com/subscribe?u=947c9b18fc27e0b00fc2ad055&id=257df01285&utm_content=buffer1ce12&utm_medium=social&utm_source=facebook.com&utm_campaign=buffer>
|
jframe
approved these changes
Nov 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
team-yeti may need to test docker publish by creating a test release branch. Docker secrets may also be required in circleci