This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Persistent nodes #332
Merged
Persistent nodes #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
suggested changes
Feb 18, 2020
There was a problem hiding this comment.
PR is looking good! There are a few suggestions along the code.
One thing that I didn't see and I believe it is missing is the cli option that can be used to delete the known nodes data during startup. Let me know when this logic is implemented and I'll do another pass on the PR!
src/test/java/net/consensys/orion/network/PersistentNetworkNodesTest.java
Show resolved
Hide resolved
|
On second thought I removed the acceptance test. It would be more meaningful to have a test with a load balancer in place and using docker. I will add env variables to this PR to speed up the work. |
|
Acceptance test passes locally. Please rerun the test? |
lucassaldanha
previously approved these changes
Feb 23, 2020
lucassaldanha
approved these changes
Feb 24, 2020
lucassaldanha
pushed a commit
to lucassaldanha/orion
that referenced
this pull request
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the draft PR adding supporting for persistence of node information.
PersistentNetworkNodesusing the same backend, showing one sends the info to the other.Note I added env support for 2 config keys here. I will add all env support in a separate PR to reduce the mess.