Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Gorc's CLI UX #378

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Improve Gorc's CLI UX #378

wants to merge 11 commits into from

Conversation

hannydevelop
Copy link
Contributor

Closes #363

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #378 (dd514f3) into main (9bf8d5d) will decrease coverage by 3.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   30.79%   26.95%   -3.84%     
==========================================
  Files          38       45       +7     
  Lines        5302     6276     +974     
==========================================
+ Hits         1633     1692      +59     
- Misses       3532     4446     +914     
- Partials      137      138       +1
Impacted Files Coverage Δ
module/x/gravity/handler.go 47.05% <0.00%> (-12.21%) ⬇️
module/x/gravity/types/ethereum.go 15.90% <0.00%> (-4.10%) ⬇️
module/x/gravity/keeper/pool.go 78.09% <0.00%> (-3.10%) ⬇️
module/x/gravity/keeper/ethereum_event_handler.go 5.08% <0.00%> (-0.23%) ⬇️
module/x/gravity/keeper/grpc_query.go 17.61% <0.00%> (-0.06%) ⬇️
module/app/app.go 0.65% <0.00%> (-0.02%) ⬇️
module/x/gravity/migrations/v1/key.go 100.00% <0.00%> (ø)
module/x/gravity/client/cli/query.go 0.00% <0.00%> (ø)
module/x/gravity/client/cli/utils.go 45.45% <0.00%> (ø)
module/x/gravity/client/cli/tx.go 0.00% <0.00%> (ø)
... and 7 more

@hannydevelop hannydevelop marked this pull request as ready for review April 6, 2022 13:53
@EricBolten
Copy link
Contributor

@hannydevelop pinging this as it has a merge conflict, will pick up the review after resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmanian zmanian Awaiting requested review from zmanian zmanian is a code owner

@EricBolten EricBolten Awaiting requested review from EricBolten

@cbrit cbrit Awaiting requested review from cbrit

@philipjames44 philipjames44 Awaiting requested review from philipjames44

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port CLI UX changes from steward to gorc
3 participants
@hannydevelop @codecov-commenter @EricBolten