Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TOC CSS style error in Chrome (invalid property value) #616

Open
2 of 3 tasks
gertvdijk opened this issue Jun 1, 2020 · 1 comment
Open
2 of 3 tasks

[BUG] TOC CSS style error in Chrome (invalid property value) #616

gertvdijk opened this issue Jun 1, 2020 · 1 comment
Labels
bug Well, it shouldn’t be doing that. Let’s fix it!
Milestone

Comments

@gertvdijk
Copy link
Contributor

Mandatory Step

  • I am using latest production release of Elegant

Recommended Step

  • I have attached link to my blog source code repository, so that developers can try to reproduce the issue at the end
  • I can't my source code but I have linked my pelican configuration files to help developers reproduce the issue

Description

Describe the bug
Enable the TOC in an article. Then observe two things.

Two parts:

  • In Google Chrome; a CSS style property value is shown as an error, and rendering as below in screenshot.
  • In Firefox, the property value is accepted, but the rendering seems odd.

I am not sure what would be the intentional rendering, with or without list items. An ordered list with numbers seems odd in a <ul>, so I suspect something else was intended with this change in #509.

To Reproduce
See description.

Expected behavior
Firefox and Chrome to render the TOC identically.

Screenshots
Error in Chrome:
Screenshot from 2020-06-01 17-23-42

Rendering in Chrome (left) vs Firefox (right):
Screenshot from 2020-06-01 17-31-41 Screenshot from 2020-06-01 17-30-49

Desktop (please complete the following information):

  • OS: Linux
  • Browser Chrome Version 83.0.4103.61 (Official Build) (64-bit), Firefox 76.0.1 (64-bit).

Smartphone (please complete the following information):
not tested.

Additional context
Seems to be caused by #509 in commit 2d597ab.

@gertvdijk gertvdijk added the bug Well, it shouldn’t be doing that. Let’s fix it! label Jun 1, 2020
@talha131 talha131 added this to the 2020 - Q2 milestone Jun 1, 2020
@talha131
Copy link
Member

talha131 commented Jun 1, 2020

Thank you. TOC needs overhaul. We haven't worked much on it since the first release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Well, it shouldn’t be doing that. Let’s fix it!
Development

No branches or pull requests

2 participants