Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch remaining usage of http.Client to use common transport #122

Closed
jhiemstrawisc opened this issue Sep 8, 2023 · 1 comment · Fixed by #137
Closed

Switch remaining usage of http.Client to use common transport #122

jhiemstrawisc opened this issue Sep 8, 2023 · 1 comment · Fixed by #137
Assignees
@joereuss12
Labels
enhancement New feature or request
Milestone
v7.1.0

Comments

@jhiemstrawisc
Copy link
Member

Hey @joereuss12, there are still a few checks of TLSSkipVerify floating around throughout some of the newer code. Can you switch your getTransport function to be exported from the pelican package and use the function wherever we're still manually checking for TLSSkipVerify? This will allow us to set up testing frameworks more easily and consistently in the future.
@jhiemstrawisc jhiemstrawisc added the enhancement New feature or request label Sep 8, 2023
@jhiemstrawisc jhiemstrawisc added this to the v7.1.0 milestone Sep 8, 2023
@joereuss12
Copy link
Contributor

Yup! My bad must have missed that. Should be a relatively simple fix.

@joereuss12 joereuss12 linked a pull request Sep 14, 2023 that will close this issue
Switched over remaining usage of http.Client to use common transport #137
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joereuss12 joereuss12

Labels
enhancement New feature or request
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging a pull request may close this issue.

Switched over remaining usage of http.Client to use common transport joereuss12/pelican
2 participants
@joereuss12 @jhiemstrawisc