-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have webdav directory listing utilize token-based authorization #25
Comments
@matyasselmeci points out this probably also breaks recursive transfers (which increases the priority to fix). |
Client side code. Interface for listing remote directories. The token isn't being passed to the web-dev library or it's being passed. "list-directory" function. Possibly customize the http headers. |
@bbockelm Looking into the code, gowebdav doesn't support this. However, there is an open issue for a fix on their repo, how do we feel about me attempting that rather than ripping out the code? |
What's the GH issue you found? We should at least get that linked to this one. |
It's linked here: studio-b12/gowebdav#61 I did look into adding the support to the base web directory, but honestly my token/http knowledge still feels to weak to do so, so instead I'm removing the isDir code and we can fix it later. |
I'm OK with fixing the directory listing / upload on a future ticket. Will merge the PR momentarily. |
We think, when stashcp does the directory existence test, it uses a library that doesn't leverage the bearer token. Investigate this issue and, as necessary, add token support.
Alternately, if token support isn't available, rip out this code.
The text was updated successfully, but these errors were encountered: