Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude generate package when building for release #459

Closed
haoming29 opened this issue Dec 5, 2023 · 0 comments · Fixed by #937
Closed

Exclude generate package when building for release #459

haoming29 opened this issue Dec 5, 2023 · 0 comments · Fixed by #937
Assignees
@haoming29
Labels
infrastructure GitHub Actions, Release management, and CI
Milestone
v7.7.0

Comments

@haoming29
Copy link
Contributor

haoming29 commented Dec 5, 2023 •
edited
Loading

As we discussed in #442, currently we include generate package and the code it generates in the release artifact. However, the generate package itself won't be used by the user as an executable, so we want to exclude them when shipping the code as binaries.

  • Modify GHA release action to exclude ./generate package when building for release
@haoming29 haoming29 added the infrastructure GitHub Actions, Release management, and CI label Dec 5, 2023
@haoming29 haoming29 self-assigned this Mar 12, 2024
@haoming29 haoming29 added this to the v7.7.0 milestone Mar 12, 2024
@haoming29 haoming29 mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haoming29 haoming29

Labels
infrastructure GitHub Actions, Release management, and CI
Projects
None yet
Milestone
v7.7.0
Development

Successfully merging a pull request may close this issue.

Remove generate package when releasing haoming29/pelican
1 participant
@haoming29