Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 component shouldn't need trailing / on PROPFIND requests #54

Closed
jhiemstrawisc opened this issue Nov 11, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@jhiemstrawisc
Copy link
Member

At the moment, failure to include a trailing / on PROPFIND requests to the S3 backend results in a "no such file or directory" without sending any requests upstream to the S3 endpoint.

$ curl -v -X PROPFIND http://localhost:8443/my-prefix

> PROPFIND /my-prefix HTTP/1.1
> Host: localhost:8443
> User-Agent: curl/7.76.1
> Accept: */*
> 
< HTTP/1.1 404 Not Found
< Connection: Close
< Server: XrootD/v5.7.1
< Content-Length: 55
< 
Unable to locate /my-prefix; no such file or directory

Whereas including the trailing / reaches the known 403 on PROPFINDs after forwarding the request to the upstream S3 endpoint:

$ curl -v -X PROPFIND http://localhost:8443/my-prefix/
> PROPFIND /my-prefix/ HTTP/1.1
> Host: localhost:8443
> User-Agent: curl/7.76.1
> Accept: */*
> 
< HTTP/1.1 403 Forbidden
< Connection: Close
< Server: XrootD/v5.7.1
< Content-Length: 54
< 
Unable to locate /my-prefix/; operation not permitted

Existing 403 bug notwithstanding, I think these two cases should be treated the same, and we should handle adding the trailing / internally for these requests.

@rw2 rw2 linked a pull request Nov 21, 2024 that will close this issue
@jhiemstrawisc jhiemstrawisc removed a link to a pull request Nov 27, 2024
@jhiemstrawisc
Copy link
Member Author

Closed by #58

@jhiemstrawisc jhiemstrawisc added the bug Something isn't working label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants