Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tensor handling from device #170

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Remove Tensor handling from device #170

merged 3 commits into from
Nov 18, 2024

Conversation

lillian542
Copy link
Contributor

@lillian542 lillian542 commented Nov 15, 2024 •
edited
Loading

andrijapau
andrijapau approved these changes Nov 18, 2024
View reviewed changes
Copy link

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
PietropaoloFrisoni
PietropaoloFrisoni reviewed Nov 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@lillian542 @PietropaoloFrisoni
Update CHANGELOG.md
37da026 
Co-authored-by: Pietropaolo Frisoni <pietropaolo.frisoni@xanadu.ai>
PietropaoloFrisoni
PietropaoloFrisoni approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.80%. Comparing base (3cdfcda) to head (37da026).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   98.80%   98.80%   -0.01%     
==========================================
  Files          10       10              
  Lines         587      586       -1     
==========================================
- Hits          580      579       -1     
  Misses          7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@lillian542 lillian542 merged commit 63343f2 into master Nov 18, 2024
11 checks passed
@lillian542 lillian542 deleted the remove_legacy_opmath branch November 18, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietropaoloFrisoni PietropaoloFrisoni PietropaoloFrisoni approved these changes

@andrijapau andrijapau andrijapau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lillian542 @andrijapau @PietropaoloFrisoni