Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests and adapt test for par_domainremoval #90

Merged
merged 17 commits into from
Dec 8, 2021

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Dec 7, 2021

Due to recent PennyLane changes, some parameters are given as array and it is not supported by Pyquil. We apply a small fix to transform the parameters to floats.

Multiple tests were also changed due to the removal of par_domain in PennyLane.

@rmoyard rmoyard changed the title Fix integration tests Fix integration tests and adapt test for par_domainremoval Dec 7, 2021
@antalszava antalszava self-requested a review December 7, 2021 22:10
Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉 As suggested, one step will be the changelog.

setup.py Outdated Show resolved Hide resolved
rmoyard and others added 2 commits December 8, 2021 09:31
Co-authored-by: antalszava <antalszava@gmail.com>
@rmoyard rmoyard merged commit 5a70aef into master Dec 8, 2021
@rmoyard rmoyard deleted the params_array branch December 8, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants