Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip3 install pennylane_pq fails on osx, dockerhub & ubuntu #52

Closed
twobombs opened this issue Jul 17, 2019 · 9 comments
Closed

pip3 install pennylane_pq fails on osx, dockerhub & ubuntu #52

twobombs opened this issue Jul 17, 2019 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@twobombs
Copy link

Screenshot 2019-07-17 at 14 42 10

package seems to miss requirements.txt

I could go back to a code build, but the 'pip3 install' is more elegant :)

Saw this happen on OSX and ARM64

@co9olguy
Copy link
Member

Thanks @twobombs, we'll have to look into this. Obviously the repo has the requirements.txt, so it's not immediately clear what the discrepancy is here

@josh146 josh146 added the bug Something isn't working label Jul 24, 2019
@twobombs
Copy link
Author

typo in packaging ?

Screenshot 2019-07-30 at 10 25 09

Screenshot 2019-07-30 at 10 24 08

@twobombs
Copy link
Author

After copy & rename requires.txt to the root of project filename requirement.txt it builds

Screenshot 2019-07-30 at 10 31 31

.... and installs

Screenshot 2019-07-30 at 10 31 57

FYI :)

@josh146
Copy link
Member

josh146 commented Jul 30, 2019

Thanks @twobombs! That helped me narrow it down - there was a bug in setup.py, where it was attempting to read and open from requirements.txt (even though it didn't need to). I've now fixed this in #53

@josh146 josh146 closed this as completed Jul 30, 2019
@twobombs
Copy link
Author

Would it be prudent to make the new release ( 0.50-dev ) avaliable on
https://pypi.org/project/PennyLane/ or does this work automatically by some trigger ?

@josh146
Copy link
Member

josh146 commented Jul 31, 2019

I might make a quick bugfix release (0.4.1) :)

@twobombs
Copy link
Author

twobombs commented Aug 6, 2019

Haven't seen a release yet on https://pypi.org/project/PennyLane/#history
So technically the bug hasn't been fixed in that the pip3 install now does work.

@co9olguy co9olguy reopened this Aug 7, 2019
@co9olguy
Copy link
Member

co9olguy commented Aug 7, 2019

Fair enough @twobombs :) I'll reopen until the update is available via pip

@josh146
Copy link
Member

josh146 commented Aug 8, 2019

Hi @twobombs, the v0.4.1 bugfix release is now available on pip 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants