Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCC Module Creating Arbitrary Empty Log Files #256

Closed
Marshall-Hallenbeck opened this issue Apr 13, 2024 · 2 comments · Fixed by #307
Closed

WCC Module Creating Arbitrary Empty Log Files #256

Marshall-Hallenbeck opened this issue Apr 13, 2024 · 2 comments · Fixed by #307
Assignees
Labels
bug Something isn't working

Comments

@Marshall-Hallenbeck
Copy link
Collaborator

Describe the bug
The WCC module has some custom logging code that creates a ton of empty log files

To Reproduce
Run the WCC module
Command: netexec smb -u username -p password -M wcc

Expected behavior
Log files should have actual data in them, or they shouldn't be created

Screenshots
image

NetExec info

  • OS: Kali
  • Version of nxc: 1.1.0 - nxc4u - b123a4d
  • Installed from: main branch, via poetry

Additional context
I think we should implement a way for any module/etc to create specific logs to their needs, i.e. if a module wants to log something for users to look up later, like files created/hashes/etc, we should have an easy logging method outside our context.log/nxc_logger

@Marshall-Hallenbeck
Copy link
Collaborator Author

Ohhh since we import the modules every nxc run it's creating the logger file EACH TIME NXC IS RAN. Definitely going to be at least fixing that shortly.

@NeffIsBack
Copy link
Contributor

NeffIsBack commented May 15, 2024

Oh god. But atleast nxc only imports all modules when -L or a specific module is specified.

But a fix would be really nice, it's anyway a bit whack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants