Better support of errors

Author: abrisse

lib/translator_text/client.rb

@@ -93,22 +93,19 @@ def post(path, params)
     # If success, return the response body
     # If failure, raise an error
     def handle_response(response)
-      case response.code
-      when 200..299
-        response
-      else
-        if response.request.format == :json
-          raise ServiceError.new(
-            code: response['error']['code'],
-            message: response['error']['message']
-          )
-        else
-          raise NetError.new(
-            code: response.code,
-            message: response.response.message
-          )
-        end
+      return response if response.code.between?(200, 299)
+
+      if response.request.format == :json && response['error']
+        raise ServiceError.new(
+          code: response['error']['code'],
+          message: response['error']['message']
+        )
       end
+
+      raise NetError.new(
+        code: response.code,
+        message: response.response.message
+      )
     end
 
     def headers

spec/translator_text/client_spec.rb

@@ -10,7 +10,7 @@
     )
   end
 
-  describe '(integrations tests)', integration: true do
+  describe '(integrations tests)', :integration do
     before(:all) do
       WebMock.disable!
     end
@@ -73,8 +73,8 @@
       'https://api.cognitive.microsofttranslator.com/translate?api-version=3.0&from=en&to=fr'
     end
 
-    before do
-      @stub = stub_request(:post, translate_url).with(
+    let!(:stub) do
+      stub_request(:post, translate_url).with(
         body: '[{"Text":"First sentence"},{"Text":"Second sentence"}]'
       ).to_return(
         body: load_response('translation_1')
@@ -88,14 +88,14 @@
 
       it 'calls the service' do
         results
-        expect(@stub).to have_been_requested
+        expect(stub).to have_been_requested
       end
     end
 
     context 'with Types::Sentence' do
       it 'calls the service' do
         results
-        expect(@stub).to have_been_requested
+        expect(stub).to have_been_requested
       end
     end
 
@@ -110,6 +110,18 @@
     it 'returns the detected language' do
       expect(results.map(&:detected_language)).to eq %i[en en]
     end
+
+    context 'with a unauthorized request' do
+      before do
+        stub_request(:post, translate_url).to_return(
+          status: 401
+        )
+      end
+
+      it 'raises a NetError' do
+        expect { results }.to raise_error(TranslatorText::NetError)
+      end
+    end
   end
 
   describe '#detect' do
@@ -128,8 +140,8 @@
       'https://api.cognitive.microsofttranslator.com/detect?api-version=3.0'
     end
 
-    before do
-      @stub = stub_request(:post, detect_url).with(
+    let!(:stub) do
+      stub_request(:post, detect_url).with(
         body: '[{"Text":"First sentence"},{"Text":"Second sentence"}]'
       ).to_return(
         body: load_response('detection_1')
@@ -143,14 +155,14 @@
 
       it 'calls the service' do
         results
-        expect(@stub).to have_been_requested
+        expect(stub).to have_been_requested
       end
     end
 
     context 'with Types::Sentence' do
       it 'calls the service' do
         results
-        expect(@stub).to have_been_requested
+        expect(stub).to have_been_requested
       end
     end
 
@@ -161,5 +173,17 @@
     it 'returns the detected language' do
       expect(results.map(&:language)).to eq %i[en en]
     end
+
+    context 'with a unauthorized request' do
+      before do
+        stub_request(:post, detect_url).to_return(
+          status: 401
+        )
+      end
+
+      it 'raises a NetError' do
+        expect { results }.to raise_error(TranslatorText::NetError)
+      end
+    end
   end
 end