Problem with bleadperl of 7/18/00 #2236
Comments
From schinder@pobox.comCreated by schinder@c22234-c.scllg1.pa.home.comI rsynced a copy of bleadperl last night EDT, 7/18/00. Looks like there's linux% ./perl -I ../lib comp/require.t Here's the perl -V for bleadperl (since I was too lazy to run perlbug linux% ./perl -I../lib -V Characteristics of this binary (from libperl): Perl Info |
From @jhiOn Wed, Jul 19, 2000 at 03:41:43PM -0000, schinder@pobox.com wrote:
The subtest #23 of the comp/require test is broken. I haven't yet had |
From [Unknown Contact. See original ticket][ Note to bugmongers: this fixes the following other bug reports: Jarkko Hietaniemi <jhi@iki.fi> wrote
The attached patch fixes this. It's a long way from ideal for the Looking at the BOM code and at the UTF16 stuff, there appears to be a i) Shouldn't the swallow_bom() call in toke.c be earlier, e.g. ii) utf16_to_utf8() in utf8.c uses U16 as if were *exactly* 2 bytes. iii) utf16_to_utf8() doesn't seem to check for odd length iv) Shouldn't the warning "Malformed UTF-16 surrogate" be a hard error? v) This comment in utf8.c is out of date :-) vi) The tests are currently a joke. E.g. the UTF16 BOM really ought vii) I didn't bother to explore exactly *why* PL_bufend needed refreshing. Mike Guy Inline Patch--- ./t/comp/require.t.orig Tue Jul 11 22:19:23 2000
+++ ./t/comp/require.t Tue Jul 25 11:01:17 2000
@@ -132,7 +132,8 @@
do_require("$utf8\nprint \"ok $i\n\"; 1;\n");
$i++;
do_require("$utf16\n1;");
-print "ok $i\n" if $@ =~ /Unsupported script encoding/;
+print "not " unless $@ =~ /^Unrecognized character /;
+print "ok $i\n";
END { 1 while unlink 'bleah.pm'; 1 while unlink 'bleah.do'; }
--- ./toke.c.orig Tue Jul 25 09:29:37 2000
+++ ./toke.c Tue Jul 25 09:41:46 2000
@@ -2519,6 +2519,7 @@
}
}
if (bof)
+ PL_bufend = SvPVX(PL_linestr) + SvCUR(PL_linestr);
s = swallow_bom((U8*)s);
incline(s);
} while (PL_doextract);
End of patch |
From [Unknown Contact. See original ticket]Mike
I have not looked at this closely, but the indendation suggests you want @@ -2519,6 +2519,9 @@ Robin |
From [Unknown Contact. See original ticket]Robin Barker <rmb1@cise.npl.co.uk> wrote
D'oh! Yes, of course I do. The amazing thing is that "make test" didn't bat an eyelid. Revised version of whole patch attached. Mike Guy Inline Patch--- ./t/comp/require.t.orig Tue Jul 25 12:31:43 2000
+++ ./t/comp/require.t Tue Jul 25 11:01:17 2000
@@ -132,7 +132,8 @@
do_require("$utf8\nprint \"ok $i\n\"; 1;\n");
$i++;
do_require("$utf16\n1;");
-print "ok $i\n" if $@ =~ /Unsupported script encoding/;
+print "not " unless $@ =~ /^Unrecognized character /;
+print "ok $i\n";
END { 1 while unlink 'bleah.pm'; 1 while unlink 'bleah.do'; }
--- ./toke.c.orig Tue Jul 25 12:31:43 2000
+++ ./toke.c Tue Jul 25 12:32:38 2000
@@ -2519,7 +2519,10 @@
}
}
if (bof)
+ {
+ PL_bufend = SvPVX(PL_linestr) + SvCUR(PL_linestr);
s = swallow_bom((U8*)s);
+ }
incline(s);
} while (PL_doextract);
PL_oldoldbufptr = PL_oldbufptr = PL_bufptr = PL_linestart = s;
End of patch |
From @jhiOn Tue, Jul 25, 2000 at 12:52:45PM +0100, M.J.T. Guy wrote:
Thanks. I'll also add/act on your notes from the earlier attempt. |
Migrated from rt.perl.org#3552 (status was 'resolved')
Searchable as RT3552$
The text was updated successfully, but these errors were encountered: