Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd80cda9a1 breaks Perl::Lexer #23016

Open
jkeenan opened this issue Feb 19, 2025 · 1 comment
Open

cd80cda9a1 breaks Perl::Lexer #23016

jkeenan opened this issue Feb 19, 2025 · 1 comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)

Comments

@jkeenan
Copy link
Contributor

jkeenan commented Feb 19, 2025

Breakage originally reported to me by Carlos Guevara (@cjg-cguevara). See, e.g., http://www.cpantesters.org/cpan/report/44092ac2-eeb8-11ef-bc13-939a1e99e01d

perl Porting/bisect.pl \
--start=7fdc8f34fd20e8d4bec8de19f64c869b152f1249 \
end=8d462f6a9e96adf5dac36c7e778468b78a47be96 \
--module=Perl::Lexer
commit cd80cda9a1e25d7a1278f9d1c7db8ab94384c124
Author: Tony Cook <tony@develop-help.com>
Date:   Mon Nov 18 15:40:50 2024 +1100
Commit:     Aristotle Pagaltzis <pagaltzis@gmx.de>
CommitDate: Sun Feb 16 14:51:17 2025 +0100

    Revert "switch removal: remove given/when/break/continue"
    
    This reverts commit dff5181acc0f5386556522c0ae4e59f672162f6e.

@tonycoz , can you take a look? Thanks.

@jkeenan jkeenan added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Needs Triage labels Feb 19, 2025
@tonycoz
Copy link
Contributor

tonycoz commented Feb 19, 2025

From looking at the module it needs an update.

This module includes a copy of the perly.h generated by regen_perly and a reformatted verson of the the token table debug_tokens[] array in toke.c, which was changed when the switch tokens were reinstated.

It might be possible for perl to provide the information needed by the author to avoid doing this type of update but I'm not aware of any requests to p5p about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Projects
None yet
Development

No branches or pull requests

2 participants