Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stashes contain CVs vs GVs now, breaking Prima in 5.41.10 #23020

Open
dk opened this issue Feb 20, 2025 · 1 comment
Open

Stashes contain CVs vs GVs now, breaking Prima in 5.41.10 #23020

dk opened this issue Feb 20, 2025 · 1 comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)

Comments

@dk
Copy link

dk commented Feb 20, 2025

Hello,

I've got a report dk/Prima#144 caused by changes in the stash structure .

I wonder if you could recommend a best course of action about this, in particular how to adapt the code that used to call GvCV(gv_fetchmeth())?
Or, possibly there is a way to keep Prima classes build the old way?

Any insight into this would be much appreciated

cc @mauke

@mauke
Copy link
Contributor

mauke commented Feb 20, 2025

gv_fetchmeth should work transparently by automatically upgrading any non-GV stash entries to full GVs before returning. So it is fine to keep using GvCV(gv_fetchmeth()) . (In particular, I believe the method call machinery can't handle bare CVs and always upgrades to GVs.)

@jkeenan jkeenan added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) and removed Needs Triage labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Projects
None yet
Development

No branches or pull requests

3 participants