-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variables for each deployment #38
Conversation
xmunoz
commented
Dec 31, 2020
•
edited
Loading
edited
- Untar repositories into a temp directory, then rsync to deploy location
- Clean up temp packages and files
- Fix Remove code dir before untar-ing #34
49a043f
to
ee4db42
Compare
- Untar repositories into a temp directory, then rsync to deploy location - Clean up temp packages and files - Fix #34
ee4db42
to
39c2f0e
Compare
c570b25
to
51d4c5f
Compare
synchronize doesn't really work when src and dest are both remote Also, use root to remove temp dir
51d4c5f
to
ea17b85
Compare
Successful image build action: https://github.com/PermanentOrg/infrastructure/actions/runs/453964464 I just deployed the new dev AMI this morning, and it looks good from the user perspective. We can confirm this together on the call later, since I no longer have SSH access. Still need to test just the code deploy action. |
Just deployed dev from this branch, and it appears to work (the queue issue is now fixed): https://github.com/PermanentOrg/infrastructure/runs/1631265467?check_suite_focus=true |
provisioners/deploy-backend.yml
Outdated
- website | ||
command: "aws s3 cp s3://permanent-repos/{{ perm_env }}/{{ item }}.tar.gz {{ temp_dir }}/{{ item }}.tar.gz" | ||
loop: "{{ repos }}" | ||
- name: Create temp untar dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought this would come before the "copy from S3" command, so the tars have somewhere to land - what am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the previous command aws s3 cp
creates that missing directory. We can remove the step that explicitly creates it, since it does nothing according to the ansible log:
TASK [Create temp untar dir] ***************************************************
task path: /home/runner/work/infrastructure/infrastructure/provisioners/deploy-cron.yml:28
ok: [ec2-34-220-107-44.***.compute.amazonaws.com] => {"changed": false, "gid": 1005, "group": "deployer", "mode": "0755", "owner": "deployer", "path": "/data/tmp/www", "size": 4096, "state": "directory", "uid": 1005}
This is made redundant by `aws s3 cp`.
Closing this because it is so out-of-date. Will reopen and adjust when needed! |