Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some calls to/usage of getWithChildren #141

Open
nfebe opened this issue Aug 10, 2022 · 0 comments
Open

Update some calls to/usage of getWithChildren #141

nfebe opened this issue Aug 10, 2022 · 0 comments

Comments

@nfebe
Copy link

nfebe commented Aug 10, 2022

The back-end currently allows api/folder/getWithChildren to be called with an array of folder VOs. It is not clear whether this ability is important in web-app, however it does not appear to used in practice some have some code references such as this one which @liam-lloyd found :

promises.push(folders.length ? this.api.folder.getWithChildren(folders) : Promise.resolve());

  • We have agreed that api/folder/getWithChildren that it is not ideal for this to expect and return children for more than 1 folder.
  • It might not be relevant in wep app after all.

This issue is then to check and make sure that:

  1. Such behavior is not needed in web-app and if so, the current references removed.
  2. Back-end's api/folder/getWithChildren is updated to never expect more than one folder if 1) is true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant