Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Full TrimMode #119

Closed
PhantomGamers opened this issue Jun 13, 2023 · 0 comments
Closed

Enable Full TrimMode #119

PhantomGamers opened this issue Jun 13, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@PhantomGamers
Copy link
Owner

This would give a nice file size reduction to the self contained version of the app.

However, currently SFP produces a lot of trim warnings and does not properly function with full TrimMode.

The biggest holdup is MartinKuschnik/WmiLight#11 for the Windows version as this causes the app to fully crash.

Aside from that, pages fail to load when TrimMode is set to full. I'm unsure what causes this, as when I tested the FluentAvalonia sample app it worked fine with full trimming. Perhaps it is due to SFP's use of ReactiveUI, but this needs further investigation.

SFP_UI_RXIvVpW7GD
@PhantomGamers PhantomGamers added enhancement New feature or request bug Something isn't working labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhantomGamers