Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet/installer repo is deprecated, does not have tags for v9 releases #7

Open
yusefnapora-sf opened this issue Dec 6, 2024 · 1 comment

Comments

@yusefnapora-sf
Copy link

yusefnapora-sf commented Dec 6, 2024

Hi, I'm evaluating proto for our dev environments and came across your plugin. I was hoping to install the recent v9 stable release, but proto lsr dotnet only shows pre-release versions for v9.

It seems that the source you're using for version tags has been deprecated by the dotnet SDK team, and the README now says that the dotnet/sdk repo will be the source of truth going forward.

I noticed a note in proto.rs that there was an issue with pre-release version tags being slightly off when sourced from dotnet/sdk, so perhaps switching over there isn't possible. But if the installer repo is no longer being updated, perhaps it would be worth combining the two sources and using dotnet/installer for versions before v9 and dotnet/sdk going forward? That may mess up future pre-release versions though, so maybe not the best solution...

At any rate, I figured it was worth bringing to your attention in case you weren't already aware. Cheers :)

@Phault
Copy link
Owner

Phault commented Dec 13, 2024

Hi,

Thanks for taking the time to report this and investigating the issue.

The sourcing of the versions are a bit of a mess as you see, but I think you're right that the correct path forward would be combining the lists. I guess the list from the deprecated repo could be baked in, to avoid introducing a second blocking fetch and since it won't change going forward anyway.

I don't personally use Proto anymore, so someone else would have to step up to do the work and I'd gladly merge a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants