Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate query-string in favour of standard URLSearchParams #5

Closed
AsakuraMizu opened this issue Aug 15, 2023 · 1 comment
Closed

Deprecate query-string in favour of standard URLSearchParams #5

AsakuraMizu opened this issue Aug 15, 2023 · 1 comment
Labels
performance Improvements on app performance

Comments

@AsakuraMizu
Copy link
Contributor

Related issue: sindresorhus/query-string#307

Benchmark shows that URLSearchParams is much faster than query-string.
bench1
@AsakuraMizu AsakuraMizu changed the title Deprecated query-string in favour of standard URLSearchParams Deprecate query-string in favour of standard URLSearchParams Aug 15, 2023
@Naptie Naptie added the performance Improvements on app performance label Aug 26, 2024
@AsakuraMizu
Copy link
Contributor Author

Since we are heavily depending on parseNumbers and parseBooleans which have no alternative with URLSearchParams, replacing query-string is almost impossible.

@AsakuraMizu AsakuraMizu closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Improvements on app performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AsakuraMizu @Naptie