Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enums for TypeScript property value lists #589

Open
reefdog opened this issue Feb 22, 2024 · 0 comments
Open

Use enums for TypeScript property value lists #589

reefdog opened this issue Feb 22, 2024 · 0 comments

Comments

@reefdog
Copy link
Contributor

reefdog commented Feb 22, 2024

As noted by @slifty in this review comment, a list of valid property values like align?: 'left' | 'right'; could use enums for the values, especially for those (like this) which we repeat.

My quick search revealed lots of places that would benefit:

to be enummed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reefdog