feat(tabs): L3-2396 tabs add controlled state #412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
L3-2395
Summary
While the Tabs component supported an
defaultValue
prop (for uncontrolled tabs with internal state), it didn't support thevalue
prop for fully controlled tabs where the parent component passes in the state externally. (This is useful for doing things like updating the URL when we switch tabs, which allows bookmarking of a page with a particular tab selected.)Change List (describe the changes made to the files)
onTabClick
toonClick
to be consistent with other buttonsTabsPrimitive.Root
in case we want to support another capability of RadixAcceptance Test (how to verify the PR)
Regression Test
Evidence of testing
Things to look for during review
feat(scope): ...
if aminor
release should be triggered.phillips
class prefix are using the prefix variabledata-testid
attribute.New Components
index.ts
filecomponentStyles.scss
file.