Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): L3-4918 responsive button change made close button the wrong style #458

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

scottdickerson
Copy link
Contributor

@scottdickerson scottdickerson commented Jan 6, 2025

Jira ticket

L3-4918

Screenshots

Before After
image
image

Summary

The IconButton design in Figma was much larger for variant=secondary buttons than it had been implemented by Seldon. This was fixed in a previous PR, but a few components were using this variant incorrectly.

Change List (describe the changes made to the files)

  • change(Drawer/Modal): change the secondary to tertiary

Acceptance Test (how to verify the PR)

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit a232e9e
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/677c362ba175cf0008d922e3
😎 Deploy Preview https://deploy-preview-458--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scottdickerson scottdickerson merged commit d4d86c5 into main Jan 6, 2025
13 checks passed
@scottdickerson scottdickerson deleted the L3-4918-responsive-button branch January 6, 2025 21:56
davidicus pushed a commit that referenced this pull request Jan 6, 2025
## [1.104.1](v1.104.0...v1.104.1) (2025-01-06)

### Bug Fixes

* **modal:** L3-4918 responsive button change made close button the wrong style ([#458](#458)) ([d4d86c5](d4d86c5))
@davidicus
Copy link
Collaborator

🎉 This issue has been resolved in version 1.104.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants