Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting a build error #267

Open
Ram-N opened this issue Sep 22, 2023 · 9 comments
Open

Getting a build error #267

Ram-N opened this issue Sep 22, 2023 · 9 comments

Comments

@Ram-N
Copy link

Ram-N commented Sep 22, 2023

I forked this repo, and under settings-->Pages, I switched to the 'gh-pages` branch. No other changes made.
And I get the following build error from Github.

Rendering: _posts/design/2015-08-16-typography.md Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/styles_feeling_responsive.scss': $number: "calc($colNumber / $totalColumns)" is not a unitless number forpercentage' on line 32
`

Any help or suggestions are appreciated. (It runs fine in my local though)

@esorolla
Copy link

esorolla commented Oct 9, 2023

I have the same problem.

@baxendaleink
Copy link

Me as well.

@baxendaleink
Copy link

baxendaleink commented Oct 30, 2023

After some brief research online, I removed the header section of the file (assets/css/styles_feeling_responsive.scss), to remove the section with the dashes, and it fixed the issue.

I cannot say why or if I've made things worse by doing so, though, because I'm too amateur here for that. As below, this is everything I removed:

---
# Only the main Sass file needs front matter, rest is included from site.sass.sass_dir
sitemap:
  exclude: true
---

So the file now looks just like this:

@charset "utf-8";

@import "functions.scss";
@import "01_settings_colors.scss";
@import "02_settings_typography.scss";
@import "03_settings_mixins_media_queries.scss";
@import "04_settings_global.scss";
@import "05_normalize.scss"; // normalize.css v3.0.2

@import "foundation-components/top-bar";
@import "foundation-components/accordion";
@import "foundation-components/alert-boxes";
@import "foundation-components/breadcrumbs";
@import "foundation-components/block-grid";
@import "foundation-components/button-groups";
@import "foundation-components/buttons";
@import "foundation-components/clearing";
@import "foundation-components/dropdown";
@import "foundation-components/dropdown-buttons";
@import "foundation-components/flex-video";
@import "foundation-components/forms";
@import "foundation-components/grid";
@import "foundation-components/inline-lists";
@import "foundation-components/keystrokes";
@import "foundation-components/panels";
@import "foundation-components/reveal";
@import "foundation-components/side-nav";
@import "foundation-components/sub-nav";
@import "foundation-components/tables";
@import "foundation-components/thumbs";
@import "foundation-components/top-bar";
@import "foundation-components/type";
@import "foundation-components/visibility";

@import "06_typography.scss";
@import "07_layout.scss";
@import "foundation-components/grid";
@import "09_elements.scss";

{% if site.asciidoctor-enabled == true %}
@import "10_asciidoc.scss";
{% endif %}

@import "11_syntax-highlighting.scss";

Hope that helped somebody.

@TWiStErRob
Copy link
Contributor

This theme on the latest commit is built with Jekyll 4 on Ruby 3. GitHub pages only supports Jekyll 3: github/pages-gem#651
I think you'll need to use a custom GitHub Actions workflow to deploy to Pages: github/pages-gem#651 (comment)

@Phlow your deployment fails since the lock file changes, because you're also using the built-in gh-pages builder. Did you mean to use latest Jekyll 4?

@baxendaleink Removing the front matter like that will result in not processing that file at all, just plain raw copy, which means your site CSS will be non-existent. Make sure you're doing a full (non-incremental) jekyll build to observe this. Here's an example diff after removing front matter:
image
this explains why the error goes away: it's simply not processed.

@baxendaleink
Copy link

No way I'd have figured that out. Thank you. :)

@sieb
Copy link

sieb commented Nov 30, 2023

I managed to solve it with Github Actions template Jekyll, just changing cache 0 to 1 cache-version: 1 # Increment this number if you need to re-download cached gems Look in https://sieb.github.io/feeling-responsive/

@simopal6
Copy link

simopal6 commented Jan 9, 2024

I managed to solve it with Github Actions template Jekyll, just changing cache 0 to 1 cache-version: 1 # Increment this number if you need to re-download cached gems Look in https://sieb.github.io/feeling-responsive/

Can you please in more detail? I also tried enabling the GitHub Action, changing cache-versionto 1, but I still get a build error.

@sieb
Copy link

sieb commented Jan 25, 2024

I managed to solve it with Github Actions template Jekyll, just changing cache 0 to 1 cache-version: 1 # Increment this number if you need to re-download cached gems Look in https://sieb.github.io/feeling-responsive/

Can you please in more detail? I also tried enabling the GitHub Action, changing cache-versionto 1, but I still get a build error.

I tested it now, in the following workflow:

  • clone the fresh repository;
  • In Actions search workflows by jekyll (jekyll only) and configure, and commit jekyll.yml (change cache-version: 1)
  • In Actions workflows, "Deploy Jekyll site to Pages" is our process, try re-run all jobs

@Nikoleta-v3
Copy link

Nikoleta-v3 commented May 5, 2024

Thank you @sieb! Your comments and suggestions where very helpful 😄 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants