Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the CI triggers for cpp jobs #1414

Closed
rdmark opened this issue Jan 15, 2024 · 1 comment
Closed

Revisit the CI triggers for cpp jobs #1414

rdmark opened this issue Jan 15, 2024 · 1 comment

Comments

@rdmark
Copy link
Member

rdmark commented Jan 15, 2024

As has been discussed back and forth in the past, we currently have CI job triggers for both pushes and pull requests. This leads to duplicate jobs every time a new commit is pushed to an active pull request.

We're on the free tier of GitHub for Teams, so computing resources are theoretically not unlimited (2000 actions minutes monthly) although I've never seen us exceed the limits yet. Our cpp jobs are quite heavy, with compilation, unit tests, and Sonar static analysis of the entire codebase (including python). A recent PR used up ~70min of computing time for each push, and with three pushes I theoretically used up 210 min of computing time, over 1/10 of the monthly allowance.

Off the top of my head, if we are already running jobs for each push to remote, do we really need the PR triggers at all?

@rdmark
Copy link
Member Author

rdmark commented Jan 19, 2024

Addressed as part of #1417

@rdmark rdmark closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant