feat(css): add css-overrides to cssMap #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pickra
requested changes
Jan 28, 2020
There was a problem hiding this comment.
hey @gcrossfield, sorry for the delayed response. I've been out of town + unplugged. This looks good but needs some documentation. At minimum, something in the README demonstrating how to use the cssOverrides at the bottom of the if-you-dont-like-the-styles-you-can-override-them section. If you wana put in a little more effort, show how it's used in an example story; you could link to that in the README too.
|
@Pickra Sorry for the delay! I've included some examples and updated the README. |
|
I'll release your update soon @gcrossfield |
|
Awesome.. thanks! |
|
ok @gcrossfield, new version is published |
|
Great news! Thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cssOverridesoption to the default options. This will retain the current styles to remain intact, while providing deeper customization options for the plugin.