Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the JavaKeywords class #1442

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Drop the JavaKeywords class #1442

merged 1 commit into from
Dec 9, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Nov 29, 2024 •
edited
Loading

Suggested commit message:

Drop the `JavaKeywords` class (#1442)

Instead:
- Move its sole used method `#isValidIdentifier` to the `SourceCode`
  class.
- Delegate most of said method's implementation to
  `javax.lang.model.SourceVersion`.

@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Nov 29, 2024
@Stephan202 Stephan202 added this to the 0.20.0 milestone Nov 29, 2024
@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 1
  • Killed mutants in this change: 5
class surviving killed
🧟tech.picnic.errorprone.utils.SourceCode 1 3
🎉tech.picnic.errorprone.utils.ConflictDetection 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

mohamedsamehsalah
mohamedsamehsalah approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean ☕

@Stephan202 @rickie
Drop the JavaKeywords class
a1ebb72 
Instead:
- Move its sole used method `#isValidIdentifier` to the `SourceCode`
  class.
- Delegate most of said method's implementation to
  `javax.lang.model.SourceVersion`.
@rickie rickie force-pushed the sschroevers/drop-JavaKeywords-class branch from 99ed7e3 to a1ebb72 Compare December 9, 2024 08:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

  • Surviving mutants in this change: 1
  • Killed mutants in this change: 5
class surviving killed
🧟tech.picnic.errorprone.utils.SourceCode 1 3
🎉tech.picnic.errorprone.utils.ConflictDetection 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Stephan202 Stephan202 merged commit db18d6a into master Dec 9, 2024
16 checks passed
@Stephan202 Stephan202 deleted the sschroevers/drop-JavaKeywords-class branch December 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @mohamedsamehsalah