Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better configuration file format? #76

Closed
Andy-Elizabeth-mouse opened this issue Feb 7, 2025 · 1 comment
Closed

Better configuration file format? #76

Andy-Elizabeth-mouse opened this issue Feb 7, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@Andy-Elizabeth-mouse
Copy link

Describe the feature you'd like
Maybe we should use a better configuration file format instead of exposing class names in the configuration file.

Is your feature request related to a problem? Please describe.
YesSteveModel/YSM-Wiki-Issues#163

@Andy-Elizabeth-mouse Andy-Elizabeth-mouse added the enhancement New feature or request label Feb 7, 2025
@PieKing1215
Copy link
Owner

Yeah it's kind of gross but I don't see any other way to do it, the point is that it means InvMove can let you configure any modded screen without needing to explicitly support it.
I don't know of any other unique id I could use other than the class name

Though note that if a class doesn't exist it isn't supposed to crash, on older versions there was a bug that could cause NoClassDefFoundError, but it should be fixed in v0.8.8 for 1.21.1 and will be ported to older/newer versions in v0.9.0 (dev builds available here)

(there is also technically a way for other mods to add their own Modules to InvMove if they want to handle their screens manually but idk if there's any mods actually using that other than InvMoveCompats)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants