Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reneme loss getter #24

Open
toodef opened this issue Aug 26, 2021 · 0 comments
Open

Reneme loss getter #24

toodef opened this issue Aug 26, 2021 · 0 comments
Assignees
@toodef
Labels
enhancement New feature or request

Comments

@toodef
Copy link
Member

toodef commented Aug 26, 2021

BaseTrainConfig.loss() should be renamed as get_loss cause misunderstanding.
Users think it's call loss module instead of getter.
@toodef toodef added the enhancement New feature or request label Aug 26, 2021
@toodef toodef self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toodef toodef

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toodef