Commit b26bf0e
authored
Fix gradient regressions, OoO support for use/gradients (#30)
* Fix gradient regressions, OoO support for use/gradients
- Defer resolution to build and assert resolution doesn't happen during parsing.
- Fix regressions introduced in the last commit around userSpaceOnUse with transforms
for linear gradients, and regressions around radial gradients in general.
- Tests
Things that are still wrong:
- I noticed while working on flutter_svg's "devil" SVG test that blends are not
being accurately applied to individual paths. I'll try to address that
in a separate PR.
- userSpaceOnUse gradients with transforms are not being applied correctly. This
has been an issue in this repo forever, not a regression. Gotta figure out how
to properly transform the gradient to the transformed path coordinate space.
See https://github.com/dnfield/flutter_svg/pull/54/files#r216222991 and the
test files added in that PR, which do not compile correctly today.
* fix inheritence for gradient properties1 parent 78761ee commit b26bf0e
File tree
9 files changed
+459
-457
lines changed- packages/vector_graphics_compiler
- lib
- src
- svg
- test
9 files changed
+459
-457
lines changedLarge diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
0 commit comments